Update descend_by_popularity scope spec #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
3 tasks
adammathys
approved these changes
Mar 14, 2023
waiting-for-dev
approved these changes
Mar 15, 2023
so that it doesn't depend on the line item quantity. The scope is not taking into account the line item quantity and was actually evaluating both line items with the same order. variant_1 was picked first only because it was created first. In fact, switching the creating order of the two variants it was failing consistently. The flaky was due to the fact that it's not guarantee that the databases will return the record in the order they are created, unless specified.
kennyadsl
force-pushed
the
kennyadsl/fix-4969-flaky-specs
branch
from
4f01e09 to
cf30c6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it doesn't depend on the line item quantity.
Closes #4977
Summary
The scope is not taking into account the line item quantity and was actually evaluating both line items with the same order. variant_1 was picked first only because it was created first.
In fact, switching the creating order of the two variants it was failing consistently.
The flaky was due to the fact that it's not guarantee that the databases will return the record in the order they are created, unless specified.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: