Fix rake error testing the update generator #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
waiting-for-dev
added
backport-v3.2
backport-v3.3
It looks like the `spree:install:migrations` task is not available when running through `Rails::Generators.invoke`, as it context differs from common shell invocation. We fix that by not trying to run the task on test environment. In the end, it wouldn't be a good idea to copy the migrations at the test suite runtime. Fixes solidusio#4978
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_missing_rake_task_warning
branch
from
c746f79 to
3bfcac6
Compare
adammathys
approved these changes
Mar 15, 2023
github-actions
bot
added
the
changelog:solidus_backend
waiting-for-dev
deleted the
waiting-for-dev/fix_missing_rake_task_warning
branch
This was referenced Mar 16, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
waiting-for-dev
removed
the
changelog:solidus_backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like the
spree:install:migrationstask is not available when running throughRails::Generators.invoke, as it context differs from common shell invocation.We fix that by not trying to run the task on test environment. In the end, it wouldn't be a good idea to copy the migrations at the test suite runtime.
Fixes #4978
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: