Add a tooltip for default currency in store settings #5009
Conversation
github-actions
bot
added
changelog:solidus_backend
kennyadsl
force-pushed
the
kennyadsl/tooltips-changing-currency
branch
from
7e0f945 to
d158fef
Compare
There was a problem hiding this comment.
Thanks, @kennyadsl! That confusion also hit me in the past.
core/config/locales/en.yml
Outdated
| @@ -1644,6 +1644,7 @@ en: | |||
| available_locales: This determines which locales are available for your customers to choose from in the storefront. | |||
| cart_tax_country_iso: 'This determines which country is used for taxes on carts (orders which don''t yet have an address).<br> Default: None.' | |||
| code: An identifier for your store. Developers may need this value if you operate multiple storefronts. | |||
| default_currency: This determines which currency will be used to retrieve product prices for this store. If you want to change it globally, set `Spree::Config.currency` instead. <br><br>Please, be aware that only products that have prices in the selected currency will be listed. | |||
There was a problem hiding this comment.
I'm still a bit confused. What do we mean by "retrieve"? Do we mean from the frontend (although we should be agnostic)? Is it also true from the API? Do we mean the default product searcher? On top of that, I think (not 100% sure), that Spree::Config.currency is the only one used when creating products on the backend.
There was a problem hiding this comment.
It's used by the current_pricing_options helper, which is used by all frontends, API and base searcher, so I think it's safe to assume that it's a valid general rule for any "storefront" instance (in fact, it is available in the store preference).
It seems to be a different thing for the backend, and probably Spree::Config.currency is used to set the default currency because the same product can be available in different stores.
If you have any suggestions on how to make it clearer, please help me! 🙂
There was a problem hiding this comment.
It's used by the current_pricing_options helper, which is used by all frontends, API and base searcher, so I think it's safe to assume that it's a valid general rule for any "storefront" instance (in fact, it is available in the store preference).
Cool. Then I think it's good enough in that regard.
It seems to be a different thing for the backend, and probably Spree::Config.currency is used to set the default currency because the same product can be available in different stores.
Do you think it is worth it to be explicit there? Like this setting won't change the default currency used when you create a product. For that, only Spree::Config.currency is taken into account.
There was a problem hiding this comment.
Rephrased, what about now?
This is just a little help for people that try to switch currency. A proper page on the guide would be a good next step.
kennyadsl
force-pushed
the
kennyadsl/tooltips-changing-currency
branch
from
d158fef to
29a520a
Compare
Summary
This PR comes from some support requests we had in Slack, highlighting some confusion when a currency switch is required. I hope this will mitigate that confusion. By the way, this is just a little help, a proper page on the guide would be a good next step.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: