Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for deprecated promo rules matching policy #5019

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove support for deprecated promo rules matching policy #5019

merged 1 commit into from
Apr 24, 2023

Conversation

kennyadsl
Copy link
Member

This PR is part of 3.x Deprecations Removal.

Summary

Matching "all" rules is the only supported path now. You can have the same effect of the previoys "any" matching policy by creating multiple promotions with the same configuration.

This change also removes the rake task we provided to update the existing promotions. That script needs to be executed on previous versions of Solidus only.

Ref #4304

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@kennyadsl
Remove support for deprecated promo rules matching policy
86cd437 
Matching "all" rules is the only supported path now. You can have the
same effect of the previoys "any" matching policy by creating multiple
promotions with the same configuration.

This change also removes the rake task we provided to update the
existing promotions. That script needs to be executed on previous
versions of Solidus only.

Ref #4304
@kennyadsl kennyadsl added type:enhancement Proposed or newly added feature release:major Breaking change on hold until next major release labels Apr 18, 2023
@kennyadsl kennyadsl self-assigned this Apr 18, 2023
@kennyadsl kennyadsl requested a review from a team as a code owner April 18, 2023 07:26
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Apr 18, 2023
@kennyadsl kennyadsl mentioned this pull request Apr 18, 2023
Closed
waiting-for-dev
waiting-for-dev approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 0bf7917 into master Apr 24, 2023
@kennyadsl kennyadsl deleted the kennyadsl/remove-promo-match-any branch April 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@kennyadsl kennyadsl

Labels
changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem release:major Breaking change on hold until next major release type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennyadsl @waiting-for-dev @adammathys