Remove Deprecated code from API component #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the shallow version of routes when possible:
- PATCH api/option_values/:id
- DELETE api/option_values/:id
- GET api/option_values/:id
And the nested route when the option type is mandatory:
- POST api/option_types/{option_type_id}/option_values
For the index routes instead, we will have both:
- GET api/option_types/{option_type_id}/option_values
- GET api/option_values
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref #4385.
We want to use the shallow version of routes when possible:
- PATCH api/variants/:id
- DELETE api/variants/:id
- GET api/variants/:id
And the nested route when the option type is mandatory:
- POST api/products/{product_id}/variants
For the index routes instead, we will have both:
- GET api/products/{product_id}/variants
- GET api/variants
Please, inherit from Spree::Api::BaseController directly. Ref #4358
Now you should create a shipment and after that, use the dedicated
endpoint to add stuff to it:
PUT /api/shipments/{shipment_number}/add
Ref #4387
For that, please use Spree::Api::Config preferences now. The helper attributes can be only used when the module is included (eg. in controllers/views context). Ref #4039
kennyadsl
added
type:enhancement
github-actions
bot
added
changelog:solidus_api
adammathys
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of 3.x Deprecations Removal.
Summary
This PR removes all the code deprecated in the API component. Please refer to each commit to better understand what has been removed and their replacements.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: