Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated factories usage #5023

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove deprecated factories usage #5023

merged 1 commit into from
Apr 24, 2023

Conversation

kennyadsl
Copy link
Member

This PR is part of 3.x Deprecations Removal.

Summary

This PR removes support for requiring individual factories from Solidus core using:

require 'spree/testing_support/factories/some_factory'

Now, you should use the provided FactoryBot.definition_file_paths. We opened this GitHub Discussion with more details, and instructions to upgrade.

Ref #3907

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@kennyadsl kennyadsl added type:enhancement Proposed or newly added feature release:major Breaking change on hold until next major release labels Apr 18, 2023
@kennyadsl kennyadsl requested a review from elia April 18, 2023 07:53
@kennyadsl kennyadsl requested a review from a team as a code owner April 18, 2023 07:53
@kennyadsl kennyadsl self-assigned this Apr 18, 2023
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 18, 2023
@kennyadsl kennyadsl mentioned this pull request Apr 18, 2023
Closed
elia
elia approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

core/lib/spree/testing_support/factory_bot.rb Outdated Show resolved Hide resolved
@kennyadsl kennyadsl marked this pull request as draft April 24, 2023 09:21
@waiting-for-dev waiting-for-dev force-pushed the kennyadsl/remove-deprecated-factories-usage branch from d64b79f to f0fab1a Compare April 24, 2023 10:20
@waiting-for-dev waiting-for-dev marked this pull request as ready for review April 24, 2023 10:24
@waiting-for-dev waiting-for-dev merged commit 8fcebb0 into solidusio:master Apr 24, 2023
@waiting-for-dev waiting-for-dev deleted the kennyadsl/remove-deprecated-factories-usage branch April 24, 2023 12:53
@kennyadsl kennyadsl mentioned this pull request Apr 28, 2023
Merged
3 tasks
waiting-for-dev added a commit to nebulab/solidus_avatax_certified that referenced this pull request Jun 1, 2023
@waiting-for-dev @filippoliverani
Use new recommended way to load factories
a1e1f54 
The old way is already deprecated in Solidus v4. See
solidusio/solidus#5023 for details.

Co-authored-by: Filippo Liverani <dev@mailvore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

@elia elia elia approved these changes

Assignees

@waiting-for-dev waiting-for-dev

@kennyadsl kennyadsl

Labels
changelog:solidus_core Changes to the solidus_core gem release:major Breaking change on hold until next major release type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennyadsl @elia @waiting-for-dev