Remove frontend related code from the core dummy app #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
waiting-for-dev
approved these changes
Apr 28, 2023
rainerdema
approved these changes
Apr 28, 2023
We are no more running frontend specs in core and we don't need to inject that code in the dummy.
kennyadsl
force-pushed
the
kennyadsl/dummy-frontend-removal
branch
from
a6c665a to
8680e00
Compare
|
Rebased and it's all green now. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #5026
We are no more running frontend specs in core and we don't need to inject that code in the dummy.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: