Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SolidusAdmin #5068

Merged
merged 344 commits into from
Sep 29, 2023
Merged

Add SolidusAdmin #5068

merged 344 commits into from
Sep 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented May 4, 2023

Add SolidusAdmin to the list solidus sub-frameworks, for now it will live in the repo and be released separately while we complete coverage for the existing backend sections.

During the intermediate phase it will be possible to keep SolidusAdmin and Spree::Backend in the same rails application and benefit immediately from the updated UI/UX of the sections covered by the new admin dashboard.

Features

  • ✨ Updated modern UI, more intuitive and familiar to modern users
  • 🧰 A dedicated UI Kit that can be used to easily create custom sections with high quality and low effort
  • 🌱 A built-in switch that allows to fall back on the legacy admin dashboard that allows a soft transition and early feedback
  • 🎛️ A components registry that will enable controlled updates to the UI/UX and to completely abandon UI monkey patching (e.g. with deface)

Action Items:

  • Consider creating an hosted demo for the new admin interface before the upcoming release. This would provide an interactive way to showcase the improvements and new features.

@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem labels May 4, 2023
@elia elia changed the title Spike branch for the new admin SolidusAdmin spike May 4, 2023
admin/README.md Outdated Show resolved Hide resolved
@elia elia force-pushed the nebulab/admin branch from b138908 to 02a9836 Compare May 5, 2023 10:06
@github-actions github-actions bot added the changelog:solidus Changes to the solidus meta-gem label May 10, 2023
@elia elia changed the title SolidusAdmin spike SolidusAdmin long running branch May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #5068 (1288f9c) into main (803be9d) will increase coverage by 0.02%.
The diff coverage is 89.30%.

❗ Current head 1288f9c differs from pull request most recent head a5372d3. Consider uploading reports for the commit a5372d3 to get more accurate results

@@            Coverage Diff             @@
##             main    #5068      +/-   ##
==========================================
+ Coverage   88.74%   88.77%   +0.02%     
==========================================
  Files         565      609      +44     
  Lines       13986    14762     +776     
==========================================
+ Hits        12412    13105     +693     
- Misses       1574     1657      +83     
Files Coverage Δ
...app/components/solidus_admin/feedback/component.rb 100.00% <100.00%> (ø)
...ponents/solidus_admin/products/status/component.rb 100.00% <100.00%> (ø)
...nts/solidus_admin/sidebar/account_nav/component.rb 100.00% <100.00%> (ø)
.../app/components/solidus_admin/sidebar/component.rb 100.00% <100.00%> (ø)
...components/solidus_admin/sidebar/item/component.rb 100.00% <100.00%> (ø)
...pp/components/solidus_admin/skip_link/component.rb 100.00% <100.00%> (ø)
...app/components/solidus_admin/ui/badge/component.rb 100.00% <100.00%> (ø)
...pp/components/solidus_admin/ui/button/component.rb 100.00% <100.00%> (ø)
...nents/solidus_admin/ui/forms/checkbox/component.rb 100.00% <100.00%> (ø)
...mponents/solidus_admin/ui/forms/field/component.rb 100.00% <100.00%> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia changed the title SolidusAdmin long running branch [admin] SolidusAdmin long running branch Jun 9, 2023
@elia elia force-pushed the nebulab/admin branch from 1e5e138 to f589fa3 Compare June 9, 2023 15:59
@elia elia changed the title [admin] SolidusAdmin long running branch [Admin] SolidusAdmin development branch (don't merge yet 🙅‍♂️) Jun 27, 2023
@elia elia added the hold On hold for a reason different from a breaking change label Jun 27, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jun 30, 2023
@waiting-for-dev waiting-for-dev force-pushed the nebulab/admin branch 2 times, most recently from 3a06dd5 to 2918e38 Compare August 9, 2023 08:46
@waiting-for-dev waiting-for-dev removed their assignment Sep 6, 2023
@elia elia force-pushed the nebulab/admin branch 2 times, most recently from 3a6c427 to 673deb7 Compare September 27, 2023 09:44
@elia elia changed the title [Admin] SolidusAdmin development branch (don't merge yet 🙅‍♂️) Add SolidusAdmin Sep 27, 2023
@elia elia added this to the 4.2 milestone Sep 28, 2023
@elia elia marked this pull request as ready for review September 28, 2023 15:26
elia added 23 commits September 29, 2023 12:37
The focus ring was not properly shown and the disabled border wasn't set.
This is a leftover from when we switched to rendering components
directly.
This will represent all input shaped elements like `input`, `textarea`
and `select`.
Those are not dependent on the authentication system.
This is temporary and will last until we get out of v0.x.
Backend should not depend on solidus_admin.
@elia elia marked this pull request as ready for review September 29, 2023 10:41
@elia elia requested a review from rainerdema September 29, 2023 10:59
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@elia elia merged commit 105a8da into main Sep 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem hold On hold for a reason different from a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants