Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the blue_steel theme #5084

Merged
merged 1 commit into from
May 23, 2023
Merged

Remove the blue_steel theme #5084

merged 1 commit into from
May 23, 2023

Conversation

elia
Copy link
Member

@elia elia commented May 23, 2023

Summary

It's been introduced in Solidus 1.2 and has been outdated for years. There was no documentation nor testing around it and is not currently working.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this May 23, 2023
@elia elia requested a review from a team as a code owner May 23, 2023 11:35
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label May 23, 2023
rainerdema
rainerdema approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

waiting-for-dev
waiting-for-dev approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 🙂

@waiting-for-dev
Copy link
Contributor

@elia, rebasing from main will fix the issue on CI thanks to dd03245 🙂

@elia
Remove the blue_steel theme
7f22e60 
It's been introduced in Solidus 1.2 and has been outdated for years.
There was no documentation nor testing around it and is not currently
working.
@elia elia force-pushed the elia/remove-old-admin-theme branch from 7d83956 to 7f22e60 Compare May 23, 2023 15:05
@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #5084 (7f22e60) into main (8438947) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5084   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         563      563           
  Lines       13889    13889           
=======================================
  Hits        12295    12295           
  Misses       1594     1594

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit a8f56d5 into main May 23, 2023
@elia elia deleted the elia/remove-old-admin-theme branch May 23, 2023 15:43
@waiting-for-dev waiting-for-dev added the type:bug Error, flaw or fault label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

@kennyadsl kennyadsl Awaiting requested review from kennyadsl

Assignees

@elia elia

Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @waiting-for-dev @rainerdema