Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document available permission sets #5141

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Document available permission sets #5141

merged 1 commit into from
Jun 13, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

This commit adds YARD documentation to the permission sets in core/lib/spree/permission_sets/.

Closes #5102

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner June 9, 2023 14:56
@waiting-for-dev waiting-for-dev self-assigned this Jun 9, 2023
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 9, 2023
kennyadsl
kennyadsl approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks! Left a question about stocks, but not blocking.

core/lib/spree/permission_sets/restricted_stock_management.rb Show resolved Hide resolved
@waiting-for-dev
Document available permission sets
56a6493 
This commit adds YARD documentation to the permission sets in
core/lib/spree/permission_sets/.

Closes solidusio#5102
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/document_permission_sets branch from 1a3d7d9 to 56a6493 Compare June 9, 2023 15:18
@waiting-for-dev waiting-for-dev merged commit ce5b5f3 into solidusio:main Jun 13, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/document_permission_sets branch June 13, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document all available permissions
3 participants
@waiting-for-dev @kennyadsl @jarednorman