-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add covered_by_store_credit
translation in en.yml
#5208
Add covered_by_store_credit
translation in en.yml
#5208
Conversation
This commit adds a new translation key 'covered_by_store_credit' in en.yml. The new key provides a specific message to inform users when their order is fully covered by store credits, and no additional payment method is required. This change is connected to an update made in Solidus Starter Frontend: solidusio/solidus_starter_frontend#348
@rainerdema did you consider adding this key to the starter fronted instead? |
This! I too think we should push translations out of core unless they're not strictly related to it. |
Sure @kennyadsl, but the starter frontend doesn't have a translations file and mainly uses those from the core at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This translation can open the way for having them in the starter solidusio/solidus_starter_frontend#348 (review)
Closing, it will be addressed with #5212 |
Summary
This PR adds a new translation key 'covered_by_store_credit' in en.yml.
The new key provides a specific message to inform users when their order is fully covered by store credits and no additional payment method is required.
This change is connected to an update made in Solidus Starter Frontend: solidusio/solidus_starter_frontend#348
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: