Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Make pagination accessible #5270

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[Admin] Make pagination accessible #5270

merged 1 commit into from
Jul 21, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

We label the pagination icon wrappers with "aria-label", while hiding the icon itself to screen readers. We also mark as "aria-disable"'d when the first/last page is reached.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner July 21, 2023 11:06
@waiting-for-dev waiting-for-dev self-assigned this Jul 21, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Jul 21, 2023
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 21, 2023
kennyadsl
kennyadsl approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocker. Thanks!

admin/app/components/solidus_admin/base_component.rb Outdated Show resolved Hide resolved
@waiting-for-dev
Make admin pagination accessible
d1790bf 
We label the pagination icon wrappers with "aria-label", while hiding
the icon itself to screen readers. We also mark as "aria-disable"'d when
the first/last page is reached.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/svg_with_meaning branch from 180400b to d1790bf Compare July 21, 2023 11:58
@waiting-for-dev waiting-for-dev merged commit 99bda34 into solidusio:nebulab/admin Jul 21, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/svg_with_meaning branch July 21, 2023 11:58
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@elia elia Awaiting requested review from elia

@rainerdema rainerdema Awaiting requested review from rainerdema

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @kennyadsl @elia