Refactor zones #530
Merged
Refactor zones #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit here is covered by #529, maybe shoot this PR at that branch instead? |
|
I'd like to, but Github doesn't let me. Would it be an option to create a branch for the VAT refactoring, and I just point all my PRs to that? |
|
Rebased. |
|
👍, good by me. |
This class method returns all those zones that have at least one member in common (even via a state that is part of a country).
Both Spree::Zone.match and Spree::Zone.with_shared_members employ almost the same SQL for doing what they need to do. Moved into a named scope to reduce understanding effort. Improve documentation, follow Rubocop recommendations
|
Sped up |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to find all zones with shared members (which will really help in finding out which tax rates apply for a particular zone, even if those rates' zone encompasses more territory than the zone in question).
This method includes a complex SQL query that
Spree::Zone#matchalso does. Moved to a scope.Furthermore, improve the documentation so it's somewhat easier to find out what all these things do.