Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore using MenuItem#sections for matching paths #5406

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 2, 2023

Summary

Using sections for matching the path was originally done inside the #tab helper, when the responsibility was moved to MenuItem this use-case was lost. Not anymore.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

elia added 2 commits October 2, 2023 19:26
Using sections for matching the path was originally done inside the
#tab helper, when the responsibility was moved to MenuItem this use-
case was lost. Not anymore.
@elia elia added the backport-v4.2 Backport this pull-request to v4.2 label Oct 2, 2023
@elia elia requested a review from rainerdema October 2, 2023 17:27
@elia elia self-assigned this Oct 2, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Oct 2, 2023
@elia elia marked this pull request as ready for review October 2, 2023 17:34
@elia elia requested a review from a team as a code owner October 2, 2023 17:34
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #5406 (d6cb238) into main (51f44e1) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5406      +/-   ##
==========================================
+ Coverage   88.84%   88.86%   +0.01%     
==========================================
  Files         608      607       -1     
  Lines       14750    14747       -3     
==========================================
  Hits        13105    13105              
+ Misses       1645     1642       -3     
Files Coverage Δ
...ckend/lib/spree/backend_configuration/menu_item.rb 98.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia requested a review from kennyadsl October 3, 2023 07:47
@elia elia merged commit 743f888 into main Oct 3, 2023
6 checks passed
@elia elia deleted the elia/menu-items-sections branch October 3, 2023 11:52
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

💚 All backports created successfully

Status Branch Result
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.2 Backport this pull-request to v4.2 changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants