[Admin] Ensure labels are clickable by parameterizing ids #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that IDs generated for labels do not contain spaces, utilizing the `parameterize` method. This resolves an issue where labels were not clickable due to invalid characters in corresponding IDs.
elia
approved these changes
Oct 11, 2023
rainerdema
deleted the
rainerd/ransack-filter/fix/parameterize-id-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In certain instances within
SolidusAdmin::UI::Table::RansackFilter::Component, labels were not clickable due to spaces in their associated IDs, which occurred when the label or option value contained spaces.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: