Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deactivate_unsupported_payment_methods name in error message #5458

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kennyadsl
Copy link
Member

In the doc printed when it's needed, we had a typo, probably due to some back and forth on the PR that introduced the change.

See #3837

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

In the doc printed when it's needed, we had a typo, probably due to some back and forth on the PR that introduced the change. 

See #3837
@kennyadsl kennyadsl self-assigned this Oct 25, 2023
@kennyadsl kennyadsl requested a review from a team as a code owner October 25, 2023 10:50
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5458 (f0bd4c6) into main (d479d6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5458   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         614      614           
  Lines       14829    14829           
=======================================
  Hits        13185    13185           
  Misses       1644     1644           
Files Coverage Δ
core/app/models/spree/payment_method.rb 94.20% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennyadsl kennyadsl merged commit a0103b7 into main Oct 25, 2023
4 checks passed
@kennyadsl kennyadsl deleted the kennyadsl/fix-deactivation-payment-name branch October 25, 2023 15:57
@elia elia changed the title Fix deactivate_unsupported_payment_methods name Fix deactivate_unsupported_payment_methods name in error message Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants