Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make promotion handler classes configurable #5466

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Oct 27, 2023

Summary

We have four promotion handlers in the codebase, but only two are actually used: the promotion handler "coupon" and the promotion handler "shipping". If one chose to use a promotion system that works different from the stock Solidus one, these two promotion handlers must be configurable.

See also friendlycart/solidus_friendly_promotions#61 because this extension point does not exist yet.

Checklist

@mamhoff mamhoff requested a review from a team as a code owner October 27, 2023 12:36
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5466 (1ceffb6) into main (b653f69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5466   +/-   ##
=======================================
  Coverage   88.96%   88.97%           
=======================================
  Files         617      617           
  Lines       14876    14878    +2     
=======================================
+ Hits        13235    13237    +2     
  Misses       1641     1641           
Files Coverage Δ
...p/controllers/spree/api/coupon_codes_controller.rb 100.00% <100.00%> (ø)
core/app/models/spree/order.rb 94.65% <100.00%> (ø)
core/lib/spree/app_configuration.rb 99.28% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elia elia merged commit 34dd484 into solidusio:main Oct 30, 2023
4 checks passed
@elia elia changed the title Configurable promotion handlers Make promotion handler classes configurable Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants