-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Add sortable rows in ui/table
component
#5522
Merged
rainerdema
merged 4 commits into
solidusio:main
from
nebulab:rainerd/admin/add-sortable-lists
Nov 29, 2023
Merged
[Admin] Add sortable rows in ui/table
component
#5522
rainerdema
merged 4 commits into
solidusio:main
from
nebulab:rainerd/admin/add-sortable-lists
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/admin/add-sortable-lists
branch
3 times, most recently
from
November 29, 2023 15:41
d998c2a
to
5560714
Compare
…request.js` The `onEnd` method, sends a PATCH request to update item positions, using `@rails/request.js` for secure AJAX calls with proper CSRF token handling. https://github.com/SortableJS/Sortable https://github.com/rails/requestjs-rails
rainerdema
force-pushed
the
rainerd/admin/add-sortable-lists
branch
from
November 29, 2023 15:41
5560714
to
88f6467
Compare
- Integrate sorting rows functionality with the `sortable_controller.js`. - Enhanced the preview section to allow enabling and disabling all table functionalities, including sorting, search, filters, batch actions, and scopes.
rainerdema
force-pushed
the
rainerd/admin/add-sortable-lists
branch
2 times, most recently
from
November 29, 2023 16:12
785f423
to
a0b8a40
Compare
3 tasks
rainerdema
changed the title
[Admin] Add sortable rows in
[Admin] Add sortable rows in Nov 29, 2023
ui/table
component + create new option types
index componentui/table
component
3 tasks
elia
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Awesome!
elia
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Admin.Add.sortable.rows.in.ui.table.component.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: