Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Refactor admin components for consistent code style #5559

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[Admin] Refactor admin components for consistent code style #5559

merged 4 commits into from
Dec 21, 2023

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Dec 20, 2023 •
edited
Loading

Summary

The focus has been on aligning all components with our established coding conventions, which include consistent formatting, method ordering, and property alignment.

Highlights of this PR include:

  1. Uniform code style across all admin components for better readability and maintainability.
  2. Introduction of pagination in components where it was missing.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Dec 20, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/uniform-admin-components-style branch from 068f4d5 to 19e0678 Compare December 21, 2023 10:07
@rainerdema rainerdema marked this pull request as ready for review December 21, 2023 10:29
@rainerdema rainerdema requested a review from a team as a code owner December 21, 2023 10:29
@rainerdema rainerdema requested a review from elia December 21, 2023 10:29
@rainerdema rainerdema merged commit f1c4920 into solidusio:main Dec 21, 2023
8 checks passed
@rainerdema rainerdema deleted the rainerd/admin/uniform-admin-components-style branch December 21, 2023 12:45
@rainerdema rainerdema mentioned this pull request Dec 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainerdema @elia