Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Remove previews for non-UI components that didn't add much value #5592

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

elia
Copy link
Member

@elia elia commented Jan 10, 2024

Summary

The coverage shouldn't drop after this change.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The coverage shouldn't drop after this change.
@elia elia self-assigned this Jan 10, 2024
@elia elia requested a review from a team as a code owner January 10, 2024 15:34
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (64f6a58) to head (d4c83e3).
Report is 1264 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5592      +/-   ##
==========================================
- Coverage   88.66%   88.65%   -0.01%     
==========================================
  Files         683      683              
  Lines       16293    16293              
==========================================
- Hits        14446    14445       -1     
- Misses       1847     1848       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia elia requested a review from rainerdema January 10, 2024 16:31
@elia elia merged commit 36a78e7 into main Jan 10, 2024
13 of 14 checks passed
@elia elia deleted the elia/admin/drop-redundant-previews branch January 10, 2024 17:10
@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 labels Jan 15, 2025
Copy link

💔 All backports failed

Status Branch Result
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.3:
- Merge pull request #3379 from nebulab/kennyadsl/sprockets-4-support
- Lock rack to be less than 3
- Add a DummyApp sprockets 4 configuration manifest
- Merge pull request #5582 from solidusio/elia/fix-select2-locales-loading-with-precompiled-assets

Manual backport

To create the backport manually run:

backport --pr 5592

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

💔 All backports failed

Status Branch Result
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.3:
- Merge pull request #3379 from nebulab/kennyadsl/sprockets-4-support
- Lock rack to be less than 3
- Add a DummyApp sprockets 4 configuration manifest
- Merge pull request #5582 from solidusio/elia/fix-select2-locales-loading-with-precompiled-assets

Manual backport

To create the backport manually run:

backport --pr 5592

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member

tvdeyen commented Jan 15, 2025

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Copy link
Member

tvdeyen commented Jan 15, 2025

💚 All backports created successfully

Status Branch Result
v4.2

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants