Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shared examples and DummyAbility require-able from outside of core #5640

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 3, 2024

Summary

This extracts all the work from #5634 that is essentially independent of extracting the promotion subsystem into its own gem, and simply allows requiring some of the shared examples and dummy classes we use in tests for other gems.

I've tried to do it in such a way that shared examples are only loaded where they're needed.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

We want to move the order_with_promotion factory.
We need this ability across several gems in the future.
This allows to check for working factories outside the core gem.
@mamhoff mamhoff requested a review from a team as a code owner February 3, 2024 12:07
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 3, 2024
@mamhoff mamhoff changed the title Legacy promos prep/extract shared examples Make shared examples and DummyAbility require-able from outside of core Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b46992) 88.56% compared to head (8823049) 88.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5640      +/-   ##
==========================================
+ Coverage   88.56%   88.60%   +0.04%     
==========================================
  Files         685      689       +4     
  Lines       16408    16473      +65     
==========================================
+ Hits        14531    14596      +65     
  Misses       1877     1877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense, thanks!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tvdeyen tvdeyen merged commit b8a277d into solidusio:main Feb 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants