Combine stock item queries in a GROUP BY query #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
|
👍 |
1 similar comment
|
👍 |
|
👍 nice. |
jordan-brough
added a commit
that referenced
this pull request
Dec 8, 2015
…tion Combine stock item queries in a GROUP BY query
This was referenced Dec 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #550
By selecting and grouping by the
stock_itemswe can skip checking that the the variant exists in this location unit-by-unit.Currently, the this will still select the stock_items's existence per-variant in the packer, but this should reduce the queries for stock items.