Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legacy promotions gem #5678

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 2, 2024

Summary

This adds a new gem to the suite, solidus_legacy_promotions. It's indended to be filled with things from core later (see #5634 ) for what it'll look like).

I would like this scaffold to be around so I can slowly chip away at the commits in #5634 without creating unreviewable PRs for the maintainers.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

mamhoff added 2 commits March 2, 2024 12:36
We want to extract the legacy promotion system from Solidus into its own
gem to facilitate moving towards solidus_promotions.
The new weights for the individual sub-projects are their duration in
seconds.
@mamhoff mamhoff requested a review from a team as a code owner March 2, 2024 11:39
@github-actions github-actions bot added changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem labels Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (49e3da4) to head (3222e60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5678   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         695      697    +2     
  Lines       16589    16597    +8     
=======================================
+ Hits        14741    14749    +8     
  Misses       1848     1848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the work this way Martin, it's super helpful!

@kennyadsl kennyadsl merged commit cb4ec7b into solidusio:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus Changes to the solidus meta-gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants