Make API independent of promotion configuration #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API gem needs to know which attributes are available by default, and that is dependent on the promotion system that is being utilized.
When the legacy promotion system is extracted into its own gem, we won't have the luxury of factories any longer and will need to stub the API of a promotion handler ourselves.
github-actions
bot
added
changelog:solidus_api
tvdeyen
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5686 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 699 699
Lines 16607 16609 +2
=======================================
+ Hits 14760 14762 +2
Misses 1847 1847 ☔ View full report in Codecov by Sentry. |
spaghetticode
approved these changes
Mar 11, 2024
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Mar 12, 2024
This spec was previously already fixed to not refer to any promotion-system-related things, but I forgot this one line in solidusio#5686.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes any usage of promotion factories from the API spec, and allows us to change the promotion configuration without any change to Solidus' API.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: