Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show theme selector if only one theme is configured #5705

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 4, 2024

Summary

There is no usecase for selecting from one theme.

Checklist

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

There is no usecase for selecting from one theme.
@tvdeyen tvdeyen requested a review from a team as a code owner April 4, 2024 15:31
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Apr 4, 2024
@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 and removed backport-v4.2 Backport this pull-request to v4.2 labels Apr 4, 2024
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvdeyen!

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (96baef2) to head (d7ce879).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5705   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         700      700           
  Lines       16653    16653           
=======================================
  Hits        14808    14808           
  Misses       1845     1845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl kennyadsl merged commit 7c889d0 into solidusio:main Apr 5, 2024
19 checks passed
Copy link

github-actions bot commented Apr 5, 2024

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants