Docker development environment improvements #5735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
tvdeyen
reviewed
May 2, 2024
The `buster` image is quite old and creates some challenges on newer ARM based Mac's, so we update to `bookworm`. To put this into context, this takes us from a Debian release in Sept 2019 to June 2023. Co-authored-by: An Stewart <andrew@super.gd> Co-authored-by: Chris Todorov <chris@super.gd> Co-authored-by: Alberto Vena <kennyadsl@gmail.com> Co-authored-by: Thomas von Deyen <thomas@vondeyen.com>
This gem has gone end-of-life and we're using a version of Selenium that supports Selenium manager, so there is no reason to keep this gem around. Read more here: https://github.com/titusfortner/webdrivers/blob/44d4c1ae865d0acd30613313b8c67a16711249ac/README.md#update-future-of-this-project Co-authored-by: An Stewart <andrew@super.gd>
Prior to increasing the shared memory size or `shm_size`, we received errors trying to run feature specs due to lack of memory. Co-authored-by: An Stewart <andrew@super.gd>
|
Hey @tvdeyen I pushed an update that uses |
Amazing. Thanks for working on this. |
kennyadsl
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a collection of fixes and quality of life improvements related to running the specs in Docker (specifically on an ARM based Mac). This includes some fixes from @kennyadsl in #5523. Special thanks to @stewart and @forkata for helping me work on this issue.
To test this PR, run these commands:
docker-compose build --build-arg RUBY_VERSION=3.1 appdocker-compose up -ddocker-compose exec app env DB=postgres bin/rspecI would also like to draw some attention to the removal of the
webdriversgem here. I believe this is the right thing to do because the project is deprecated and we're on a version of selenium that supports managing it's own drivers with selenium-manager, but I do worry some developers could be unintentionally impacted here, so I'm curious what others think.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: