Clear order promotions in Omnes event #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
mamhoff
force-pushed
the
clear-order-promotions-in-omnes-event
branch
2 times, most recently
from
deb6741 to
3b3877e
Compare
mamhoff
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5754 +/- ##
=======================================
Coverage 88.87% 88.88%
=======================================
Files 708 709 +1
Lines 16825 16835 +10
=======================================
+ Hits 14953 14963 +10
Misses 1872 1872 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
May 16, 2024
tvdeyen
approved these changes
May 17, 2024
kennyadsl
reviewed
May 21, 2024
This adds a subscriber that removes all connected order promotions upon emptying the order. A future commit will emit the event instead of directly removing the join table records.
This is where it belongs.
mamhoff
force-pushed
the
clear-order-promotions-in-omnes-event
branch
from
3b3877e to
914d1aa
Compare
kennyadsl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves clearing the connected order promotions upon emptying an order into an
Omnes::Subscriber. This saves us from having to overrideSpree::Order#empty!in thesolidus_legacy_promotionsgem.Checklist
The following are mandatory for all PRs: