Re-add translation for match_choices
#5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving the legacy promotion system translations, I also moved the translation for `spree.match_choices`. These are also used on the backend products edit page, and need to stay in core.
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5765 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 711 711
Lines 16879 16879
=======================================
Hits 15008 15008
Misses 1871 1871 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
May 29, 2024
tvdeyen
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When moving the legacy promotion system translations, I also moved the translation for
spree.match_choices. These are also used on the backend products edit page, and need to stay in core.