Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tailwind CSS in core dummy app #5798

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 19, 2024

This allows running the core dummy app with the Tailwind required for setting sails towards the new frontend.

@mamhoff mamhoff requested a review from a team as a code owner June 19, 2024 15:11
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 19, 2024
tvdeyen
tvdeyen previously approved these changes Jun 19, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on this 👍🏻

We need to make sure all extensions have tailwindcss-rails installed in solidus_dev_support

@tvdeyen tvdeyen self-requested a review June 19, 2024 15:17
@tvdeyen tvdeyen dismissed their stale review June 19, 2024 15:17

need to add content

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 9.43396% with 48 lines in your changes missing coverage. Please review.

Project coverage is 88.68%. Comparing base (97f9f69) to head (1d2d045).

Files Patch % Lines
...idus_admin/testing_support/dummy_app/rake_tasks.rb 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5798      +/-   ##
==========================================
- Coverage   88.92%   88.68%   -0.25%     
==========================================
  Files         719      721       +2     
  Lines       16944    16997      +53     
==========================================
+ Hits        15068    15073       +5     
- Misses       1876     1924      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This allows running the core dummy app with the Tailwind required for
setting sails towards the new frontend.
@mamhoff mamhoff force-pushed the support-tailwind-in-dummy-app branch from 7003a9c to e1b1a48 Compare June 20, 2024 09:21
@github-actions github-actions bot added changelog:solidus_admin and removed changelog:solidus_core Changes to the solidus_core gem labels Jun 20, 2024
@mamhoff mamhoff force-pushed the support-tailwind-in-dummy-app branch from a788857 to b9351c3 Compare June 20, 2024 09:47
@mamhoff mamhoff force-pushed the support-tailwind-in-dummy-app branch from b9351c3 to 1d2d045 Compare June 20, 2024 09:58
@tvdeyen tvdeyen merged commit b555db8 into solidusio:main Jun 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants