[Admin] Create new Store Credit Reasons #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadelineCollier
force-pushed
the
admin-new-store-credit-reaon
branch
from
1c828b8 to
edb5533
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5820 +/- ##
==========================================
+ Coverage 88.74% 88.76% +0.02%
==========================================
Files 735 736 +1
Lines 17172 17201 +29
==========================================
+ Hits 15239 15269 +30
+ Misses 1933 1932 -1 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for this issue but it doesn't have an issue ID yet as the issue is still in draft. The update functionality will follow in a second PR to keep things small and easy to review.
This PR migrates the creation of new store credit reasons to the new admin interface, following the existing pattern used for tax categories and refund reasons.
The form is rendered via a modal dialog on the store credit reasons list by leveraging Turbo frames. Successful creation leads to a turbo stream page refresh, which updates the existing list preserving the query params and the scroll position, for a consistent UX.
The attached video shows the functionality visually:
Screen.Recording.2024-08-12.at.4.40.01.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: