Remove unused load methods & Add more request spec coverage #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These controllers were based off an example controller in which the `load_[resource_name]` method was needed. However in these cases it looks like this method is not being used, so we should be safe to remove these unused methods from these controllers.
While the bulk of our coverage comes from feature tests, the Codecov percentage was sufferring as smaller portions of our controllers were going untested without these types of specs. Adding them fixes our decreases in our Codecov percentage and adds peace of mind.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5825 +/- ##
==========================================
+ Coverage 88.84% 89.03% +0.19%
==========================================
Files 737 737
Lines 17224 17188 -36
==========================================
+ Hits 15302 15304 +2
+ Misses 1922 1884 -38 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Aug 14, 2024
rainerdema
approved these changes
Aug 14, 2024
MadelineCollier
deleted the
remove-unused-load-methods-add-request-specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on the removals:
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: