Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy wallet payment source on source destroy #5836

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 27, 2024

Summary

A wallet payment source without an actual payment source does not make any sense.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner August 27, 2024 12:17
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Aug 27, 2024
@tvdeyen tvdeyen force-pushed the destroy-wallet-payment-source-on-source-destroy branch from fef6d92 to 6391ff2 Compare August 27, 2024 12:31
A wallet payment source without an actual payment source
does not make any sense.
@tvdeyen tvdeyen force-pushed the destroy-wallet-payment-source-on-source-destroy branch from 6391ff2 to 4ca261c Compare August 29, 2024 09:52
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (127d02c) to head (4ca261c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5836   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files         744      744           
  Lines       17343    17343           
=======================================
  Hits        15460    15460           
  Misses       1883     1883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 580da1d into solidusio:main Aug 29, 2024
14 checks passed
@tvdeyen tvdeyen deleted the destroy-wallet-payment-source-on-source-destroy branch August 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants