Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing API promotions specs #5859

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

MadelineCollier
Copy link
Contributor

Summary

Three of these examples were failing with the following error:

 NameError:
   uninitialized constant Spree::Api::OpenStruct

         OpenStruct.new(
         ^^^^^^^^^^

Requiring ostruct and ensuring the correct scope is used when referencing OpenStruct fixes the errors.

Screenshot 2024-09-23 at 1 23 53 PM Screenshot 2024-09-23 at 1 24 18 PM

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Three of these examples were failing with the following error:

     NameError:
       uninitialized constant Spree::Api::OpenStruct

             OpenStruct.new(
             ^^^^^^^^^^

Requiring ostruct and ensuring the correct scope is used when
referencing OpenStruct fixes the errors.
@MadelineCollier MadelineCollier requested a review from a team as a code owner September 23, 2024 11:24
@github-actions github-actions bot added the changelog:solidus_api Changes to the solidus_api gem label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (72920b8) to head (f7cea4b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5859      +/-   ##
==========================================
+ Coverage   87.87%   89.23%   +1.35%     
==========================================
  Files         477      752     +275     
  Lines       11656    17510    +5854     
==========================================
+ Hits        10243    15625    +5382     
- Misses       1413     1885     +472     
Flag Coverage Δ
89.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdeyen tvdeyen merged commit 7b4addf into solidusio:main Sep 23, 2024
14 checks passed
@mamhoff
Copy link
Contributor

mamhoff commented Sep 25, 2024

Thank you, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants