Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Promotions): Return 200 on benefits#edit #5997

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Dec 4, 2024

In #5981, we accidentally set this render to a response code 422. Since this is the initial render of the form, it should stay a 200.

In solidusio#5981, we accidentally set this render to a response code 422.
Since it's really the initial render of the form, it should stay a 200.
@mamhoff mamhoff requested a review from a team as a code owner December 4, 2024 08:03
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Dec 4, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit e2f5282 into solidusio:main Dec 4, 2024
13 of 14 checks passed
@tvdeyen tvdeyen added the backport-v4.4 Backport this pull-request to v4.4 label Dec 6, 2024
@tvdeyen
Copy link
Member

tvdeyen commented Dec 6, 2024

backporting issue should be fixed by #6016

@tvdeyen tvdeyen added backport-v4.4 Backport this pull-request to v4.4 and removed backport-v4.4 Backport this pull-request to v4.4 labels Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

💔 All backports failed

Status Branch Result
v4.4 Cherrypick failed because the selected commit (f9c577e) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 5997

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_promotions Changes to the solidus_promotions gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants