Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Raise Rails 7.2 deprecations #6009

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −8
Open

CI: Raise Rails 7.2 deprecations #6009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b88d2e4
CI: Raise Rails deprecations
tvdeyen Dec 5, 2024
2c92b63
CI: Only test Rails 7.2 and 8.0 for now
tvdeyen Dec 5, 2024
3992e39
CI: Eager Load classes before tests
tvdeyen Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ executors:
environment: &environment
DEFAULT_MAX_WAIT_TIME: 10
SOLIDUS_RAISE_DEPRECATIONS: true
RAILS_DEPRECATIONS_BEHAVIOR: raise
CIRCLE_TEST_REPORTS: /tmp/test-results
CIRCLE_ARTIFACTS: /tmp/test-artifacts
BUNDLE_WITHOUT: "lint,release"
Expand Down Expand Up @@ -352,7 +353,7 @@ workflows:
{
parameters:
{
rails: ["7.0", "7.1", "7.2"],
rails: ["7.2"],
ruby: ["3.1"],
database: ["mysql"],
paperclip: [true],
Expand All @@ -364,8 +365,8 @@ workflows:
{
parameters:
{
rails: ["7.0", "7.1", "7.2"],
ruby: ["3.1"],
rails: ["7.2"],
ruby: ["3.2"],
database: ["postgres"],
paperclip: [false],
},
Expand All @@ -376,8 +377,8 @@ workflows:
{
parameters:
{
rails: ["7.1"],
ruby: ["3.2"],
rails: ["7.2"],
ruby: ["3.3"],
database: ["sqlite"],
paperclip: [false],
},
Expand All @@ -388,8 +389,8 @@ workflows:
{
parameters:
{
rails: ["7.2", "main"],
ruby: ["3.3.5"],
rails: ["8.0"],
ruby: ["3.3"],
database: ["sqlite"],
paperclip: [false],
},
Expand Down
2 changes: 1 addition & 1 deletion core/lib/spree/testing_support/dummy_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class Application < ::Rails::Application
config.log_level = :debug

# Improve test suite performance:
config.eager_load = false
config.eager_load = ENV['CI'].present?
config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=3600' }
config.cache_store = :memory_store

Expand Down
Loading