Admin stock locations form

[chaimann]

Summary

Adds a page with form for stock locations create/update, as well as updates stock locations table with links to go to edit page.

Updates "ui/forms/checkbox" component to contain common layout and logic reused between all checkboxes in admin forms, separating a "checkbox" component as a single element into its own component "ui/checkbox". - split to #6275

Adds helper methods .back, .discard and .save for UI button components

Adds missing tests for refund reasons, tax categories and product forms, where missing hidden input prevented booleans to be saved properly. - split to #6275

Page screenshot:

There are a few differences from the design card which I believe make sense to have:

• "Name" and "Internal Name" are placed on the same row;
• "Address" panel is a reused component "ui/forms/address", so the placement of the fields is different from the design;
• there is no email column in stock_locations, and the "Phone" field is included in "ui/forms/address", so "Phone" field is not placed in its own section; email column is added and phone + email placed in their own address fieldset;
• "Active" is a checkbox rather than select field, since it's a boolean;
• texts for hints are copied from current backend; there is currently no hint for "Default" checkbox there so I haven't added any hint for "Set as default for all products";

Checklist

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (48de765) to head (8f9d2b2).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6160      +/-   ##
==========================================
+ Coverage   89.23%   89.31%   +0.08%     
==========================================
  Files         955      959       +4     
  Lines       20079    20116      +37     
==========================================
+ Hits        17917    17967      +50     
+ Misses       2162     2149      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[chaimann]

test failure seems to be one of those intermittent

[chaimann]

@kennyadsl @tvdeyen hey guys, you might have missed this one, can I get some eyes 👀 please?

[tvdeyen]

Can we extract the address component changes into a separate PR please? This change warrants more visibility in changelogs.

[tvdeyen]

@chaimann are there any chances to split up this PR? There are lot of changes in here that are worth it's own changelog entry

[chaimann]

@tvdeyen

are there any chances to split up this PR

Absolutely! Just to clarify and for the future PRs, what kind of changes would be good candidates to split? Here I assume it should be checkbox component changes. Maybe migration as well? Not sure, as I've seen other PRs where migration was included along with main changes, so I also put it here. Anything else?

[tvdeyen]

There is no hard rules. Anything that is tangential to the current work or worth a changelog entry because it changes the schema (as in your case) or makes a significant change to a shared component. Again, not a hard rules, more like a rule of thumb and a gut feeling "ah, that might interest others and is worth a special note in the changelog".

Anything else in well written commit messages (but you already do that), so that future contributors can make sense of a certain change.

In this case I think it is worth to have a dedicated PR about the schema change of spree_stores and maybe the checkbox component, if they are easy to extract.

I hope to finish the github actions work soon, so that extra PRs are not that much of a hassle as of right now.

Thanks for all the great work on the new admin