Fix the media queries used for our grid #791
Conversation
|
👍 Looks good to me In your opinion should we backport this to the 1.2 branch? |
|
Good question. Yes, this should have been a part of the left navigation introduction. |
|
Good fix for an unfortunate problem. It's too bad we don't have element queries for this. Maybe a comment? |
|
@graygilmore pointed out to me that this is used by both frontend and backend. We probably want to make this change only on the backend. |
|
Yes, I will pull this out of core and put a file in each of the backend/frontend. Then I'll be able to use |
We need to make changes to how the skeleton operates in the backend with the addition of the left navigation. Unfortunately, the changes required would apply to both the admin and the frontend so we need to separate these files. Ideally, the admin and the frontend wouldn't share any assets at all which this commit also pushes us in the direction of.
Since we added the left-side navigation our media queries haven't been accounted for. This commit fixes an issue where content would be off the page and a horizontal scroll bar would appear.
graygilmore
force-pushed
the
fix_media_queries
branch
from
4e2178b to
ca054f8
Compare
|
@Sinetheta moved the file into Sass-land so I can do @jhawthorn added a new commit which addresses the admin/front-end issue: graygilmore@a30a920 |
|
👍 again from me |
|
👍 |
Fix the media queries used for our grid
This fixes a bug where content would be cut off. This is a simple stop-gap before we rewrite this properly.
Before:
After:
