Move header title and actions out of 16 column skeleton #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murph33
changed the title
Murph33
force-pushed
the
improve_admin_header_spacing
branch
from
72a266b to
58dbbe9
Compare
Use a flexbox to align the content in the content-header. This is semantically better than using a table display for non-tabular data and is a move away from the 16 column skeleton that we will be eliminating.
Murph33
force-pushed
the
improve_admin_header_spacing
branch
from
58dbbe9 to
308d7aa
Compare
| </div> | ||
| </div> | ||
| <% if content_for?(:page_actions) %> | ||
| <ul class="header-actions page-actions inline-menu"> |
There was a problem hiding this comment.
I have a feeling like we might want to keep the data-hook="toolbar" here. @jhawthorn what are your thoughts on maintaining that kind of thing?
There was a problem hiding this comment.
I agree. We gain nothing by removing it here.
This div is an extraneous element to the page polluting the markup so it will be removed.
This is not touched anywhere in the code base and should be removed.
Murph33
force-pushed
the
improve_admin_header_spacing
branch
from
308d7aa to
9467853
Compare
|
Merged in #1012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving away from the skeleton and would like to move the page title and page actions out to the edges. This is a stripped down version of #959 implementing @graygilmore's suggestions since we weren't sure about making the header sticky at crunch time (opinions at #630 please).
Before
After