Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paranoia dependency explicitly #183

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

cedum
Copy link
Contributor

@cedum cedum commented Feb 14, 2020

Paranoia is being removed from Solidus core in favor of discard. See PR solidusio/solidus#3488 and the related discussions solidusio/solidus#3393 and solidusio/solidus#2354

This adds paranoia dependency explicitly until we'll refactor the User
model
here to use discard.

Paranoia is being removed from Solidus core in favor of discard.
This adds paranoia dependency explicitly until we'll refactor the User
model here to use discard.
@cedum cedum mentioned this pull request Feb 14, 2020
8 tasks
@cedum cedum requested a review from spaghetticode February 14, 2020 15:45
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedum thank you 👍

@kennyadsl kennyadsl merged commit 9a1e7fa into solidusio:master Mar 16, 2020
@cedum cedum deleted the explicit-paranoia-dependency branch March 27, 2020 17:09
kennyadsl added a commit to nebulab/solidus_auth_devise that referenced this pull request Jan 29, 2021
This is needed with Solidus 3.0 because we dropped
paranoia enterely and it's not a core dependency anymore.

It was added as runtime dependecy with solidusio#183 but the require
wasn't here yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants