Add option to skip migrations #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jarednorman
approved these changes
Oct 4, 2020
|
Specs should be fixed with #195. Let's wait to merge that one and then we can rebase here. |
|
#195 has been merged. 🙂 |
In some cases (in particular, the solidus install) it makes sense to skip the entire migration block. With the current setup, it's impossible to not run migrations AND not be asked if you want to run migrations. This allows for a complete skip of the migrations + the question asking part, which will smooth out the Solidus installation.
seand7565
force-pushed
the
add_skip_migrations_option
branch
from
9310b6e to
8f96456
Compare
|
Rebased! 😄 |
kennyadsl
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (in particular, the solidus install) it makes sense
to skip the entire migration block. With the current setup, it's
impossible to not run migrations AND not be asked if you want to
run migrations. This allows for a complete skip of the migrations
We should also release on rubygems after this PR is accepted, so the change is in effect for Solidus 2.11 - at which point, this will be an issue. Thanks!