Fix master build #147
Fix master build #147
Conversation
The store factory was updated in solidusio/solidus#3849 Although I see the "with_args" helper is being used elsewhere to allow for asserting against dynamic payloads, the only reason this value is changing on us is because of the unspoken dependency on the attributes in a solidus factory. If Solidus is going to embrace this kind of churn then we'd probably be best to set all relevant attributes explicitly.
|
@Sinetheta Hey there! 👋 Thanks for the fixes, I think that the first one should be addressed now that a new version is cut. |
Sinetheta
force-pushed
the
sinetheta/more-green
branch
from
2fbba30 to
ef239ca
Compare
|
Hi @kennyadsl I've dropped the last commit. |
|
👋🏻 Hi @Sinetheta! |
|
Hey Jared! @kennyadsl that failure looks like it might be a Circle config issue
Maybe the env is in the wrong "context" in the GUI? |
|
@AlessioRocco can you help us here? Is the CI supposed to run correctly? |
|
@Sinetheta |
|
@Sinetheta did you created (by following) a CircleCI project for this repo in your own account? I think that by doing that CircleCI will use your own conf and variables so it doesn't pass the ones we defined in the main repo. Can you please check and confirm it's that? If yes, I think that removing your project (by unfollowing?) will fix the issue. LMK! |
Sinetheta
force-pushed
the
sinetheta/more-green
branch
2 times, most recently
from
a43a3b2 to
2ada973
Compare
Here we are attempting to parse arbitrary input as generated object IDs. In version 1.10.8 there was a bug fix which moved some error handling code down deeper to the base 64 decoder. In order to support both versions of the decoder we'll need to rescue both types of exceptions.
Sinetheta
force-pushed
the
sinetheta/more-green
branch
from
2ada973 to
413a78c
Compare
|
Sorry @kennyadsl you're right I didn't notice that this PR was building in my fork of the project. FYI it wasn't enough to unfollow the project, there's now a "Stop Building" button in the Project Settings that I had to push. |
Hey all, I've included here 2 small fixes to solidus_graphql_api
and a temporary workaround for the current canonical-rails problem.The first fix is to specify a factory attribute which changed in Solidus master solidusio/solidus#3849
The second is to rescue a novel exception raised by newer versions of the gem graphql rmosolgo/graphql-ruby#2896