Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Locale.all and all_locales_options #109

Merged
merged 5 commits into from
Feb 15, 2018
Merged

Improve Locale.all and all_locales_options #109

merged 5 commits into from
Feb 15, 2018

Commits on Feb 9, 2018

  1. Add spec against SolidusI18n::Locale.all

    @jhawthorn
    jhawthorn committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    56173ba View commit details
    Browse the repository at this point in the history

  2. Use I18n.available_locales in Locale.all 

    Previously this used Dir[] inside the locales directory. This didn't
allow for locales coming from different gems. For this reason it also
didn't include :en.
    @jhawthorn
    jhawthorn committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    0c386db View commit details
    Browse the repository at this point in the history

  3. Avoid duplicate :en locales in all_locales_options

    @jhawthorn
    jhawthorn committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    4a839a3 View commit details
    Browse the repository at this point in the history

  4. Add specs for all_locales_options

    @jhawthorn
    jhawthorn committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    ea9fa3f View commit details
    Browse the repository at this point in the history

  5. Ensure locales have unique names 

    Previously, we listed both en-IN as "English (UK)" and es-MX as
"Castellano (ES)".

This commit adds a spec to ensure that the locales have a unique names
and updates the two offending locales.
    @jhawthorn
    jhawthorn committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    0a4451e View commit details
    Browse the repository at this point in the history