Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pt-BR i18n #142

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Improve pt-BR i18n #142

merged 1 commit into from
Oct 4, 2019

Conversation

rubenochiavone
Copy link
Contributor

No description provided.

kennyadsl
kennyadsl approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all the changes but I'm sure they are well done. 🇧🇷Thanks!

@rubenochiavone
Copy link
Contributor Author

I made a small mistake refactoring email values and changed the keys ☹️

@rubenochiavone
Copy link
Contributor Author

In summary

  • Fix Envio typo it was Enviro
  • Change Email to E-mail
  • Fix Meta placement
  • Change zip to CEP and zipcode to Código postal

Hope it helps 😃

@gustavopergola
Copy link

I don't understand all the changes but I'm sure they are well done. Thanks!

Not that it was needed, but i just checked and it's fine :)

@spaghetticode spaghetticode merged commit 491575f into solidusio:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubenochiavone @gustavopergola @kennyadsl @spaghetticode