Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate translations from French file #144

Merged

Conversation

coorasse
Copy link
Collaborator

These translations are already included in rails-i18n gem, which is necessary anyway when using another language other than English. This PR removes these translations from the French file. Note that they are not present in any other language in this gem (correctly)

Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coorasse 🎉

@kennyadsl
Copy link
Member

@solidusio/core-team can we have another review here, please?

Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇫🇷

@coorasse coorasse merged commit 276c58d into solidusio:master Apr 5, 2019
@coorasse coorasse deleted the feature/remove_duplicate_translations branch April 5, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants