Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Translations for Backend #148

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Added Translations for Backend #148

merged 1 commit into from
Feb 17, 2020

Conversation

hefan
Copy link
Contributor

@hefan hefan commented Feb 6, 2019

Product Screens, Promotions, User, Hints

@kennyadsl
Copy link
Member

@hefan can you please rebase?

@tvdeyen can you please take a look? 🇩🇪

@hefan
Copy link
Contributor Author

hefan commented Jan 30, 2020

ok, its rebased

tvdeyen
tvdeyen reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I found some capitalization "issues" and there are lots of typos. Wanna check again? I only marked some of them.

config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
@hefan
Copy link
Contributor Author

hefan commented Feb 13, 2020

ok, i have checked all capitalization issues and typos and fixed them

tvdeyen
tvdeyen approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke. Das sieht sehr gut aus.

@kennyadsl
Copy link
Member

@hefan Hey there! Can you please squash commits into a single one?

@hefan
Copy link
Contributor Author

hefan commented Feb 17, 2020

ok. last 3 commits squashed

@kennyadsl
Copy link
Member

Thanks @hefan!

@kennyadsl kennyadsl merged commit f0924d5 into solidusio:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@coorasse coorasse Awaiting requested review from coorasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hefan @kennyadsl @tvdeyen