Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rubocop to the CI checks #155

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Add Rubocop to the CI checks #155

merged 3 commits into from
Aug 5, 2019

Conversation

coorasse
Copy link
Collaborator

@coorasse coorasse commented Apr 6, 2019

We have rubocop? Let's use it!

kennyadsl
kennyadsl approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍for me!

spaghetticode
spaghetticode approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @coorasse 👍

@coorasse coorasse merged commit 0ae0b4c into master Aug 5, 2019
@coorasse coorasse deleted the check_rubocop branch August 5, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@alepore alepore Awaiting requested review from alepore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coorasse @spaghetticode @kennyadsl