Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of Japanese file #16

Merged
merged 3 commits into from
Feb 23, 2017
Merged

Update of Japanese file #16

merged 3 commits into from
Feb 23, 2017

Conversation

soramugi
Copy link
Contributor

Was updated was not enough translation file.

@tvdeyen
Copy link
Member

tvdeyen commented Feb 7, 2017

@soramugi could you please rebase your branch with latest version from master and review your changes. I merged #66 before being your PR. Sorry.

@soramugi
Copy link
Contributor Author

@tvdeyen No problem. Merged the latest state. Verification please 😄

tvdeyen
tvdeyen approved these changes Feb 23, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually meant rebase so we get rid of the merge commit, but its ok. Thanks

@tvdeyen tvdeyen merged commit 4abcb7a into solidusio:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soramugi @tvdeyen