-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es translations #167
Add es translations #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but I'd love the eye of a native Spanish speaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jacobherrington Spanish looks ok in the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manuca muchas gracias 👍
@@ -871,7 +871,7 @@ es: | |||
areas: Ubicaciones | |||
checkout: Reembolsos y Devoluciones | |||
configuration: Configuración | |||
display_order: Mostrar Pedido | |||
display_order: Orden de presentación |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Not sure about this translation 👉 👈
I preferred the other one. But Spanish is so different depending on the region.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 , the problem is that this is not related to Orders but to the order with which items are displayed on the screen. The previous translation was literally implying that this meant "displaying an order" which is wrong.
Out of context is hard to spot this one, I noticed it on the Admin Panel, it simply didn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @manuca . I think that the translation makes sense as the menu makes reference to the order in which product within a taxon are displayed on listing pages and search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!
In that case, totally make sense. Thank you so mucho for clear this doubt 🙌
Thank you 😄
Adds missing translations for the Spanish main locale (es):
es.spree.view_product
es.spree.master_sku
es.spree.admin.tabs.zones
es.spree.filter
es.spree.modify_stock_count