Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es translations #167

Merged
merged 9 commits into from
Jan 10, 2020
Merged

Conversation

manuca
Copy link
Contributor

@manuca manuca commented Nov 27, 2019

Adds missing translations for the Spanish main locale (es):

  • es.spree.view_product
  • es.spree.master_sku
  • es.spree.admin.tabs.zones
  • es.spree.filter
  • es.spree.modify_stock_count

@manuca manuca changed the title Add spanish strings Add es translations Nov 27, 2019
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but I'd love the eye of a native Spanish speaker.

Copy link

@softr8 softr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@memotoro
Copy link

@jacobherrington Spanish looks ok in the file.

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca muchas gracias 👍

@@ -871,7 +871,7 @@ es:
areas: Ubicaciones
checkout: Reembolsos y Devoluciones
configuration: Configuración
display_order: Mostrar Pedido
display_order: Orden de presentación
Copy link

@EduardoGHdez EduardoGHdez Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Not sure about this translation 👉 👈

I preferred the other one. But Spanish is so different depending on the region.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 , the problem is that this is not related to Orders but to the order with which items are displayed on the screen. The previous translation was literally implying that this meant "displaying an order" which is wrong.

Out of context is hard to spot this one, I noticed it on the Admin Panel, it simply didn't make sense.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @manuca . I think that the translation makes sense as the menu makes reference to the order in which product within a taxon are displayed on listing pages and search.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

In that case, totally make sense. Thank you so mucho for clear this doubt 🙌

Thank you 😄

@spaghetticode spaghetticode merged commit 30848aa into solidusio:master Jan 10, 2020
@manuca manuca deleted the add-spanish-strings branch January 20, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants