Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing german translations necessary for backend #174

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

hefan
Copy link
Contributor

@hefan hefan commented Jun 16, 2020

Contains necessary translations when using the backend in german. Otherwise the following errors occur on a fresh install:

app/views/spree/admin/orders/index.html.erb:153
translation missing: de.date.formats.default
app/views/spree/admin/shared/_js_locale_data.html.erb:9
undefined method `reject' for "translation missing: de.date.month_names":String
backend/vendor/assets/javascripts/solidus_admin/flatpickr/flatpickr.js:2167
TypeError: weekdays.join is not a function
(needs de.date.abbr_day_names)
/app/views/spree/admin/shared/_order_summary.html.erb:52
translation missing: de.time.formats.solidus.long

@hefan hefan changed the title add missing german translations add missing german translations necessary for backend Jul 15, 2020
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We should not maintain Rails translations in this file here.

config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/de.yml Show resolved Hide resolved
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke :)

@tvdeyen tvdeyen merged commit 009567f into solidusio:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants