Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert de translations from solidus 1.2 -> 1.3 #35

Merged
merged 3 commits into from
May 10, 2016

Conversation

luukveenis
Copy link
Contributor

Recent changes made to admin translations in solidus moved many of the keys. This was done to better use the ActiveModel translation conventions.

I wrote a script that scans through the locale files in solidus_i18n looking for missing keys when compared to en.yml in core. Since these translations are just moved, the script attempts to make the same moves in this locale as were made for english.

Reviews would be appreciated to find any blatant mistranslations.

Thomas von Deyen and others added 2 commits May 10, 2016 20:24
@jhawthorn jhawthorn merged commit 0bec866 into solidusio:master May 10, 2016
@jhawthorn
Copy link
Contributor

Thank you Luuk and Thomas.

@jhawthorn jhawthorn deleted the update-de-translations branch May 10, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants